feat: replicate IPreRoomUserLeave and IPostRoomUserLeave event in meteor method and add removedBy to IRoomUserLeaveContext #32724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0cfa318 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32724 +/- ##
===========================================
- Coverage 55.53% 55.49% -0.04%
===========================================
Files 2632 2632
Lines 57175 57174 -1
Branches 11842 11841 -1
===========================================
- Hits 31751 31728 -23
- Misses 22737 22759 +22
Partials 2687 2687
Flags with carried forward coverage won't be shown. Click here to find out more. |
d-gubert
previously approved these changes
Jul 10, 2024
|
This doesn't strictly require the PR on the Apps-Engine side, it will trigger the event in the new place and send the new context, even if the app won't get to see the info yet. We can treat those as separate (it does not need to wait for the new alpha version of the apps-engine and then update) |
pierre-lehnen-rc
requested changes
Jul 11, 2024
pierre-lehnen-rc
previously approved these changes
Jul 11, 2024
d-gubert
approved these changes
Jul 11, 2024
d-gubert
changed the title
pierre-lehnen-rc
approved these changes
Jul 12, 2024
d-gubert
approved these changes
Jul 12, 2024
gabriellsh
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
CORE-498
Depends on RocketChat/Rocket.Chat.Apps-engine#779
Steps to test or reproduce
Further comments